Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing XML files #185 #186

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Polishing XML files #185 #186

merged 1 commit into from
Nov 24, 2015

Conversation

kazuki43zoo
Copy link
Contributor

Please review #185 .

@@ -17,6 +16,10 @@
</param-value>
</context-param>

<listener>
<listener-class>org.terasoluna.gfw.web.logging.HttpSessionEventLoggingListener</listener-class>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be added by another commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not added. It replaced definition order.

[Before]

  • ContextLoaderListener
  • HttpSessionEventLoggingListener
  • context-param for ContextLoaderListener

[After]

  • ContextLoaderListener
  • context-param for ContextLoaderListener
  • HttpSessionEventLoggingListener

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

making added a commit that referenced this pull request Nov 24, 2015
@making making merged commit 8598a1f into master Nov 24, 2015
@making making deleted the issues/185_polishing-xmls branch November 24, 2015 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants